Skip to content

router: Remove PathMatchType and PathMatchCriterion - #20649

Merged
mattklein123 merged 3 commits into
envoyproxy:mainfrom
tpetkov-VMW:remove_path_match_criterion
Apr 6, 2022
Merged

router: Remove PathMatchType and PathMatchCriterion#20649
mattklein123 merged 3 commits into
envoyproxy:mainfrom
tpetkov-VMW:remove_path_match_criterion

Conversation

@tpetkov-VMW

@tpetkov-VMW tpetkov-VMW commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Toma Petkov tpetkov@vmware.com

Commit Message: Remove PathMatchType enum and PathMatchCriterion class, as they aren't used anywhere.
Additional Description: PathMatchCriterion class is never instantiated anywhere, besides for inheritance and testing.
Risk Level: Low
Testing: Unit test (test/common/router)
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Toma Petkov
Remove PathMatchType and PathMatchCriterion
fa06dae 
Signed-off-by: Toma Petkov <tpetkov@vmware.com>
@tpetkov-VMW

tpetkov-VMW commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Proposal to remove PathMatchCriterion, based only on the codebase.
If there are, for example, pending changes that depend on it, I'll just close the PR.

Toma Petkov and others added 2 commits April 5, 2022 10:16
@wrowe
wrowe requested a review from htuch April 6, 2022 00:59
@wrowe

wrowe commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

@htuch it appears you merged and @mrice32 made the initial contribution, if we can get some insight on why it goes unused, or approval to remove it?

@wrowe

wrowe commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

/assign-from envoyproxy/envoy-maintainers

@repokitteh-read-only

repokitteh-read-only Bot commented Apr 6, 2022

Copy link
Copy Markdown

envoyproxy/envoy-maintainers assignee is @mattklein123

🐱

Caused by: a #20649 (comment) was created by @wrowe.

see: more, trace.

mattklein123
mattklein123 approved these changes Apr 6, 2022
View reviewed changes

@mattklein123 mattklein123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall the history on this. It seems fine to remove. Thank you!

@mattklein123
mattklein123 merged commit 7014ce6 into envoyproxy:main Apr 6, 2022
@htuch

htuch commented Apr 6, 2022

Copy link
Copy Markdown
Member

+1

@tpetkov-VMW
tpetkov-VMW deleted the remove_path_match_criterion branch April 6, 2022 05:38
@stevenzzzz

stevenzzzz commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

hi there, this PR breaks our system, I think we need to reverse this PR if no strong opinion.

TLDR we need this field to take a peek into how route selection works.

Please see the original issue/PR for reference: #2531

@stevenzzzz

stevenzzzz commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

@htuch

@mattklein123

mattklein123 commented Apr 12, 2022

Copy link
Copy Markdown
Member

Sure feel free to revert but please add comments/tests that make it clear this is used in private extensions so it doesn't get removed again.

@stevenzzzz

stevenzzzz commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

thanks. @adisuissa could you please revert this as we've discussed.

adisuissa added a commit that referenced this pull request Apr 12, 2022
@adisuissa
Revert "router: Remove PathMatchType and PathMatchCriterion (#20649)"
6067669 
This reverts commit 7014ce6.
adisuissa added a commit to adisuissa/envoy that referenced this pull request Apr 12, 2022
@adisuissa
Revert "router: Remove PathMatchType and PathMatchCriterion (envoypro…
3f6957d 
…xy#20649)"

This reverts commit 7014ce6.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@yanavlasov yanavlasov mentioned this pull request Apr 13, 2022
Merged
yanavlasov pushed a commit that referenced this pull request Apr 13, 2022
@adisuissa
Revert "router: Remove PathMatchType and PathMatchCriterion (#20649)" (…
03efacf 
…#20797)

* Revert "router: Remove PathMatchType and PathMatchCriterion (#20649)"

This reverts commit 7014ce6.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
vehre-x41 pushed a commit to vehre-x41/envoy that referenced this pull request Apr 19, 2022
@adisuissa @vehre-x41
Revert "router: Remove PathMatchType and PathMatchCriterion (envoypro…
d3c133e 
…xy#20649)" (envoyproxy#20797)

* Revert "router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)"

This reverts commit 7014ce6.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
@tpetkov-VMW @ravenblackx
router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)
95db4cf 
Signed-off-by: Toma Petkov <tpetkov@vmware.com>
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
@adisuissa @ravenblackx
Revert "router: Remove PathMatchType and PathMatchCriterion (envoypro…
b52e402 
…xy#20649)" (envoyproxy#20797)

* Revert "router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)"

This reverts commit 7014ce6.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@JordanFaust JordanFaust mentioned this pull request Sep 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes
@htuch htuch Awaiting requested review from htuch

Assignees

@mattklein123 mattklein123

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tpetkov-VMW @wrowe @htuch @stevenzzzz @mattklein123