fix: detect octet-stream ICS attachments - #13732
Conversation
|
Thanks for opening your first pull request in this repository! 鉁岋笍 |
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates calendar attachment detection for .ics files labeled application/octet-stream, preserving existing MIME behavior.
Changes:
- Added case-insensitive
.icsfilename detection. - Added positive and negative unit-test coverage.
| File | Description |
|---|---|
tests/鈥婾nit/鈥婥ontroller/鈥婱essagesControllerTest.php |
Covers MIME and extension combinations. |
lib/鈥婥ontroller/鈥婱essagesController.php |
Detects octet-stream ICS attachments. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks a lot for your pr 馃憤 Looks good 馃檹 Please sign off your commits: https://github.com/nextcloud/mail/pull/13732/checks?check_run_id=108473040545 If AI was used to create this PR, please add a Assisted-By trailer to the commit message. More details at: https://github.com/nextcloud/mail/blob/main/AGENTS.md#commit-message-format |
930a750 to
48b7730
Compare
Assisted-by: ChatGPT:gpt-5.6-sol Signed-off-by: tayfuryldzz <yildiztayfur668@gmail.com>
48b7730 to
f4374d8
Compare
|
Updated the commit trailer to the AGENTS.md format and kept the DCO Signed-off-by trailer. The branch now points to f4374d8. |
|
/backport to stable5.12 please |
Fixes #13688
Summary
Validation